-
Notifications
You must be signed in to change notification settings - Fork 279
iOS Camera Permission #5906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS Camera Permission #5906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60a2afc6a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
b2e43eb to
70c1151
Compare
537c8af to
3d1d360
Compare
3d1d360 to
aa30c76
Compare
Originally opened a PR on the wrong branch, but comments still valid: #5901
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Fix camera permission accuracy by syncing OS status to Redux and updating the scan modal to use it.
checkAndRequestPermissioninto a thunk that requests when denied and dispatchesPERMISSIONS/UPDATEScanModaltodispatch(checkAndRequestPermission('camera')), improve null/typing checks, resolve bridge withundefined, and handle album errors more safelySceneHeaderwithSceneHeaderUi4and adjust header marginsfixed: Inaccurate camera permissions detectionWritten by Cursor Bugbot for commit aa30c76. This will update automatically on new commits. Configure here.