Skip to content

Conversation

@Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Jan 16, 2026

Originally opened a PR on the wrong branch, but comments still valid: #5901

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Fix camera permission accuracy by syncing OS status to Redux and updating the scan modal to use it.

  • Convert checkAndRequestPermission into a thunk that requests when denied and dispatches PERMISSIONS/UPDATE
  • Update ScanModal to dispatch(checkAndRequestPermission('camera')), improve null/typing checks, resolve bridge with undefined, and handle album errors more safely
  • Replace SceneHeader with SceneHeaderUi4 and adjust header margins
  • Add CHANGELOG entry: fixed: Inaccurate camera permissions detection

Written by Cursor Bugbot for commit aa30c76. This will update automatically on new commits. Configure here.


Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60a2afc6a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@Jon-edge Jon-edge changed the title Jon/fix/ios camera permission test-feta Jan 16, 2026
@Jon-edge Jon-edge changed the title test-feta iOS Camera Permission Jan 16, 2026
@Jon-edge Jon-edge mentioned this pull request Jan 16, 2026
6 tasks
@Jon-edge Jon-edge force-pushed the jon/fix/ios-camera-permission branch 2 times, most recently from b2e43eb to 70c1151 Compare January 16, 2026 23:42
@Jon-edge Jon-edge force-pushed the jon/fix/ios-camera-permission branch 2 times, most recently from 537c8af to 3d1d360 Compare January 17, 2026 00:36
@Jon-edge Jon-edge force-pushed the jon/fix/ios-camera-permission branch from 3d1d360 to aa30c76 Compare January 17, 2026 06:37
@Jon-edge Jon-edge enabled auto-merge January 17, 2026 06:38
@Jon-edge Jon-edge disabled auto-merge January 17, 2026 06:38
@Jon-edge Jon-edge enabled auto-merge January 17, 2026 06:40
@Jon-edge Jon-edge merged commit 7c3f338 into develop Jan 17, 2026
4 checks passed
@Jon-edge Jon-edge deleted the jon/fix/ios-camera-permission branch January 17, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants